Fix - S3 OLCI L2 extends layer with CC #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trension' of https://github.com/sentinel-hub/sentinelhub-js into fix/let_s3_olci_l2_use_cloud_cover
… into fix/let_s3_olci_l2_use_cloud_cover
|
Intention of this fix would appear clearer if all commits are squashed into one with message eg. "Fix S3 OLCI L2 for Cloud Coverage to work properly" (+rebased on master). That would possibly help readers tiny bit reading such git message 😃. |
guss84
requested changes
Aug 20, 2024
guss84
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hello.planet.com/code/sentinel-hub/sentinel-frontend/cdse/copernicus-browser/-/issues/208
S3 OLCI does not support cloud coverage, but S3 OLCI L2 does, so I just extended the class with AbstractSentinelHubV3WithCCLayer and added some missing functions specific to S3 OLCI